FIX for "mb_detect_encoding() expects parameter 1 to be string, resource given"#13
Open
spidgorny wants to merge 182 commits intofirephp:masterfrom
Open
FIX for "mb_detect_encoding() expects parameter 1 to be string, resource given"#13spidgorny wants to merge 182 commits intofirephp:masterfrom
spidgorny wants to merge 182 commits intofirephp:masterfrom
Conversation
… and getOption() methods
Code style clean up
Add Composer support to FirePHP Core
Fix homepage url
… defined at fb.php file
Modify composer.json in order to load global functions defined at fb.php file
Will now automatically run in tests folder, by just typing ‘phpunit’
PHPUnit: now auto-runs tests without folder argument
Fix is_resource() bug Conflicts: .gitignore CHANGELOG.md README.md lib/FirePHPCore/FirePHP.class.php package.json workspace/README.md workspace/package.json workspace/program.json workspace/scripts/build.js workspace/tpl/readme.tpl.md
Member
|
You need to send a diff against latest master. This PR has many old changes in it that are already on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When one of the debug arrays contains a resource, is_resource() function sometimes does not detect it well.
See http://php.net/manual/en/function.is-resource.php#103942 for details.
This is the fix for the situation.